pastebin - collaborative debugging tool
nrubsig.kpaste.net RSS


msnfs41client: Patch for better WSL support, reparse rework, fix cmd_mklink/softlinks, EA debugging+misc, 2025-02-03
Posted by Anonymous on Mon 3rd Feb 2025 18:04
raw | new post

  1. From b793054640a0cad5de7b652d30805a4a5fc48b6b Mon Sep 17 00:00:00 2001
  2. From: Roland Mainz <roland.mainz@nrubsig.org>
  3. Date: Mon, 3 Feb 2025 13:14:29 +0100
  4. Subject: [PATCH 1/8] build.vc19,include,sys: Add infrastructure to support
  5.  more types of reparse points
  6.  
  7. Add infrastructure to support more types of reparse points than
  8. just |IO_REPARSE_TAG_SYMLINK|.
  9.  
  10. Signed-off-by: Cedric Blancher <cedric.blancher@gmail.com>
  11. ---
  12. build.vc19/nfs41_driver/nfs41_driver.vcxproj  |   2 +
  13.  .../nfs41_driver/nfs41_driver.vcxproj.filters |   6 +
  14.  include/win_reparse.h                         | 185 ++++++++++++++++++
  15.  sys/nfs41sys_debug.c                          |  67 +++++++
  16.  sys/nfs41sys_debug.h                          |   1 +
  17.  sys/nfs41sys_driver.h                         |   6 +
  18.  sys/nfs41sys_reparse.c                        | 117 +++++++++++
  19.  sys/nfs41sys_symlink.c                        |  12 +-
  20.  8 files changed, 394 insertions(+), 2 deletions(-)
  21.  create mode 100644 include/win_reparse.h
  22.  create mode 100644 sys/nfs41sys_reparse.c
  23.  
  24. diff --git a/build.vc19/nfs41_driver/nfs41_driver.vcxproj b/build.vc19/nfs41_driver/nfs41_driver.vcxproj
  25. index 0fe0199..1148548 100644
  26. --- a/build.vc19/nfs41_driver/nfs41_driver.vcxproj
  27. +++ b/build.vc19/nfs41_driver/nfs41_driver.vcxproj
  28. @@ -218,6 +218,7 @@
  29.      <ClCompile Include="..\..\sys\nfs41sys_mount.c" />
  30.      <ClCompile Include="..\..\sys\nfs41sys_openclose.c" />
  31.      <ClCompile Include="..\..\sys\nfs41sys_readwrite.c" />
  32. +    <ClCompile Include="..\..\sys\nfs41sys_reparse.c" />
  33.      <ClCompile Include="..\..\sys\nfs41sys_symlink.c" />
  34.      <ClCompile Include="..\..\sys\nfs41sys_util.c" />
  35.      <ClCompile Include="..\..\sys\nfs41sys_updowncall.c" />
  36. @@ -229,6 +230,7 @@
  37.      <ClInclude Include="..\..\sys\nfs41_driver.h" />
  38.      <ClInclude Include="..\..\sys\wmlkm.h" />
  39.      <ClInclude Include="..\..\daemon\nfs_ea.h" />
  40. +    <ClInclude Include="..\..\include\win_reparse.h" />
  41.    </ItemGroup>
  42.    <ItemGroup>
  43.      <ResourceCompile Include="..\..\sys\nfs41_driver.rc" />
  44. diff --git a/build.vc19/nfs41_driver/nfs41_driver.vcxproj.filters b/build.vc19/nfs41_driver/nfs41_driver.vcxproj.filters
  45. index 2ecd6f3..49049a7 100644
  46. --- a/build.vc19/nfs41_driver/nfs41_driver.vcxproj.filters
  47. +++ b/build.vc19/nfs41_driver/nfs41_driver.vcxproj.filters
  48. @@ -61,6 +61,9 @@
  49.      <ClCompile Include="..\..\sys\nfs41sys_readwrite.c">
  50.        <Filter>Source Files</Filter>
  51.      </ClCompile>
  52. +    <ClCompile Include="..\..\sys\nfs41sys_reparse.c">
  53. +      <Filter>Source Files</Filter>
  54. +    </ClCompile>
  55.      <ClCompile Include="..\..\sys\nfs41sys_symlink.c">
  56.        <Filter>Source Files</Filter>
  57.      </ClCompile>
  58. @@ -87,6 +90,9 @@
  59.      <ClInclude Include="..\..\daemon\nfs_ea.h">
  60.        <Filter>Header Files</Filter>
  61.      </ClInclude>
  62. +    <ClInclude Include="..\..\include\win_reparse.h">
  63. +      <Filter>Header Files</Filter>
  64. +    </ClInclude>
  65.    </ItemGroup>
  66.    <ItemGroup>
  67.      <ResourceCompile Include="..\..\sys\nfs41_driver.rc">
  68. diff --git a/include/win_reparse.h b/include/win_reparse.h
  69. new file mode 100644
  70. index 0000000..0f4cd8d
  71. --- /dev/null
  72. +++ b/include/win_reparse.h
  73. @@ -0,0 +1,185 @@
  74. +/* NFSv4.1 client for Windows
  75. + * Copyright (C) 2024-2025 Roland Mainz <roland.mainz@nrubsig.org>
  76. + *
  77. + * Roland Mainz <roland.mainz@nrubsig.org>
  78. + *
  79. + * This library is free software; you can redistribute it and/or modify it
  80. + * under the terms of the GNU Lesser General Public License as published by
  81. + * the Free Software Foundation; either version 2.1 of the License, or (at
  82. + * your option) any later version.
  83. + *
  84. + * This library is distributed in the hope that it will be useful, but
  85. + * without any warranty; without even the implied warranty of merchantability
  86. + * or fitness for a particular purpose.  See the GNU Lesser General Public
  87. + * License for more details.
  88. + *
  89. + * You should have received a copy of the GNU Lesser General Public License
  90. + * along with this library; if not, write to the Free Software Foundation,
  91. + * Inc., 51 Franklin Street, Fifth Floor, Boston, MA
  92. + */
  93. +
  94. +#ifndef _NFS41_WIN_REPARSE_
  95. +#define _NFS41_WIN_REPARSE_ 1
  96. +
  97. +/*
  98. + * Header for Windows reparse point info
  99. + */
  100. +
  101. +#ifndef IO_REPARSE_TAG_MOUNT_POINT
  102. +#define IO_REPARSE_TAG_MOUNT_POINT          (0xA0000003)
  103. +#endif
  104. +#ifndef IO_REPARSE_TAG_HSM
  105. +#define IO_REPARSE_TAG_HSM                  (0xC0000004)
  106. +#endif
  107. +#ifndef IO_REPARSE_TAG_DRIVE_EXTENDER
  108. +#define IO_REPARSE_TAG_DRIVE_EXTENDER       (0x80000005)
  109. +#endif
  110. +#ifndef IO_REPARSE_TAG_HSM2
  111. +#define IO_REPARSE_TAG_HSM2                 (0x80000006)
  112. +#endif
  113. +#ifndef IO_REPARSE_TAG_SIS
  114. +#define IO_REPARSE_TAG_SIS                  (0x80000007)
  115. +#endif
  116. +#ifndef IO_REPARSE_TAG_WIM
  117. +#define IO_REPARSE_TAG_WIM                  (0x80000008)
  118. +#endif
  119. +#ifndef IO_REPARSE_TAG_CSV
  120. +#define IO_REPARSE_TAG_CSV                  (0x80000009)
  121. +#endif
  122. +#ifndef IO_REPARSE_TAG_DFS
  123. +#define IO_REPARSE_TAG_DFS                  (0x8000000A)
  124. +#endif
  125. +#ifndef IO_REPARSE_TAG_FILTER_MANAGER
  126. +#define IO_REPARSE_TAG_FILTER_MANAGER       (0x8000000B)
  127. +#endif
  128. +#ifndef IO_REPARSE_TAG_SYMLINK
  129. +#define IO_REPARSE_TAG_SYMLINK              (0xA000000C)
  130. +#endif
  131. +#ifndef IO_REPARSE_TAG_IIS_CACHE
  132. +#define IO_REPARSE_TAG_IIS_CACHE            (0xA0000010)
  133. +#endif
  134. +#ifndef IO_REPARSE_TAG_DFSR
  135. +#define IO_REPARSE_TAG_DFSR                 (0x80000012)
  136. +#endif
  137. +#ifndef IO_REPARSE_TAG_DEDUP
  138. +#define IO_REPARSE_TAG_DEDUP                (0x80000013)
  139. +#endif
  140. +#ifndef IO_REPARSE_TAG_APPXSTRM
  141. +#define IO_REPARSE_TAG_APPXSTRM             (0xC0000014)
  142. +#endif
  143. +#ifndef IO_REPARSE_TAG_NFS
  144. +#define IO_REPARSE_TAG_NFS                  (0x80000014)
  145. +#endif
  146. +#ifndef IO_REPARSE_TAG_FILE_PLACEHOLDER
  147. +#define IO_REPARSE_TAG_FILE_PLACEHOLDER     (0x80000015)
  148. +#endif
  149. +#ifndef IO_REPARSE_TAG_DFM
  150. +#define IO_REPARSE_TAG_DFM                  (0x80000016)
  151. +#endif
  152. +#ifndef IO_REPARSE_TAG_WOF
  153. +#define IO_REPARSE_TAG_WOF                  (0x80000017)
  154. +#endif
  155. +#ifndef IO_REPARSE_TAG_WCI
  156. +#define IO_REPARSE_TAG_WCI                  (0x80000018)
  157. +#endif
  158. +#ifndef IO_REPARSE_TAG_WCI_1
  159. +#define IO_REPARSE_TAG_WCI_1                (0x90001018)
  160. +#endif
  161. +#ifndef IO_REPARSE_TAG_GLOBAL_REPARSE
  162. +#define IO_REPARSE_TAG_GLOBAL_REPARSE       (0xA0000019)
  163. +#endif
  164. +#ifndef IO_REPARSE_TAG_CLOUD
  165. +#define IO_REPARSE_TAG_CLOUD                (0x9000001A)
  166. +#endif
  167. +#ifndef IO_REPARSE_TAG_CLOUD_1
  168. +#define IO_REPARSE_TAG_CLOUD_1              (0x9000101A)
  169. +#endif
  170. +#ifndef IO_REPARSE_TAG_CLOUD_2
  171. +#define IO_REPARSE_TAG_CLOUD_2              (0x9000201A)
  172. +#endif
  173. +#ifndef IO_REPARSE_TAG_CLOUD_3
  174. +#define IO_REPARSE_TAG_CLOUD_3              (0x9000301A)
  175. +#endif
  176. +#ifndef IO_REPARSE_TAG_CLOUD_4
  177. +#define IO_REPARSE_TAG_CLOUD_4              (0x9000401A)
  178. +#endif
  179. +#ifndef IO_REPARSE_TAG_CLOUD_5
  180. +#define IO_REPARSE_TAG_CLOUD_5              (0x9000501A)
  181. +#endif
  182. +#ifndef IO_REPARSE_TAG_CLOUD_6
  183. +#define IO_REPARSE_TAG_CLOUD_6              (0x9000601A)
  184. +#endif
  185. +#ifndef IO_REPARSE_TAG_CLOUD_7
  186. +#define IO_REPARSE_TAG_CLOUD_7              (0x9000701A)
  187. +#endif
  188. +#ifndef IO_REPARSE_TAG_CLOUD_8
  189. +#define IO_REPARSE_TAG_CLOUD_8              (0x9000801A)
  190. +#endif
  191. +#ifndef IO_REPARSE_TAG_CLOUD_9
  192. +#define IO_REPARSE_TAG_CLOUD_9              (0x9000901A)
  193. +#endif
  194. +#ifndef IO_REPARSE_TAG_CLOUD_A
  195. +#define IO_REPARSE_TAG_CLOUD_A              (0x9000A01A)
  196. +#endif
  197. +#ifndef IO_REPARSE_TAG_CLOUD_B
  198. +#define IO_REPARSE_TAG_CLOUD_B              (0x9000B01A)
  199. +#endif
  200. +#ifndef IO_REPARSE_TAG_CLOUD_C
  201. +#define IO_REPARSE_TAG_CLOUD_C              (0x9000C01A)
  202. +#endif
  203. +#ifndef IO_REPARSE_TAG_CLOUD_D
  204. +#define IO_REPARSE_TAG_CLOUD_D              (0x9000D01A)
  205. +#endif
  206. +#ifndef IO_REPARSE_TAG_CLOUD_E
  207. +#define IO_REPARSE_TAG_CLOUD_E              (0x9000E01A)
  208. +#endif
  209. +#ifndef IO_REPARSE_TAG_CLOUD_F
  210. +#define IO_REPARSE_TAG_CLOUD_F              (0x9000F01A)
  211. +#endif
  212. +#ifndef IO_REPARSE_TAG_APPEXECLINK
  213. +#define IO_REPARSE_TAG_APPEXECLINK          (0x8000001B)
  214. +#endif
  215. +#ifndef IO_REPARSE_TAG_PROJFS
  216. +#define IO_REPARSE_TAG_PROJFS               (0x9000001C)
  217. +#endif
  218. +#ifndef IO_REPARSE_TAG_LX_SYMLINK
  219. +#define IO_REPARSE_TAG_LX_SYMLINK           (0xA000001D)
  220. +#endif
  221. +#ifndef IO_REPARSE_TAG_STORAGE_SYNC
  222. +#define IO_REPARSE_TAG_STORAGE_SYNC         (0x8000001E)
  223. +#endif
  224. +#ifndef IO_REPARSE_TAG_STORAGE_SYNC_FOLDER
  225. +#define IO_REPARSE_TAG_STORAGE_SYNC_FOLDER  (0x90000027)
  226. +#endif
  227. +#ifndef IO_REPARSE_TAG_WCI_TOMBSTONE
  228. +#define IO_REPARSE_TAG_WCI_TOMBSTONE        (0xA000001F)
  229. +#endif
  230. +#ifndef IO_REPARSE_TAG_UNHANDLED
  231. +#define IO_REPARSE_TAG_UNHANDLED            (0x80000020)
  232. +#endif
  233. +#ifndef IO_REPARSE_TAG_ONEDRIVE
  234. +#define IO_REPARSE_TAG_ONEDRIVE             (0x80000021)
  235. +#endif
  236. +#ifndef IO_REPARSE_TAG_PROJFS_TOMBSTONE
  237. +#define IO_REPARSE_TAG_PROJFS_TOMBSTONE     (0xA0000022)
  238. +#endif
  239. +#ifndef IO_REPARSE_TAG_AF_UNIX
  240. +#define IO_REPARSE_TAG_AF_UNIX              (0x80000023)
  241. +#endif
  242. +#ifndef IO_REPARSE_TAG_LX_FIFO
  243. +#define IO_REPARSE_TAG_LX_FIFO              (0x80000024)
  244. +#endif
  245. +#ifndef IO_REPARSE_TAG_LX_CHR
  246. +#define IO_REPARSE_TAG_LX_CHR               (0x80000025)
  247. +#endif
  248. +#ifndef IO_REPARSE_TAG_LX_BLK
  249. +#define IO_REPARSE_TAG_LX_BLK               (0x80000026)
  250. +#endif
  251. +#ifndef IO_REPARSE_TAG_WCI_LINK
  252. +#define IO_REPARSE_TAG_WCI_LINK             (0xA0000027)
  253. +#endif
  254. +#ifndef IO_REPARSE_TAG_WCI_LINK_1
  255. +#define IO_REPARSE_TAG_WCI_LINK_1           (0xA0001027)
  256. +#endif
  257. +
  258. +#endif /* !_NFS41_WIN_REPARSE_ */
  259. diff --git a/sys/nfs41sys_debug.c b/sys/nfs41sys_debug.c
  260. index eb7ab0e..8706565 100644
  261. --- a/sys/nfs41sys_debug.c
  262. +++ b/sys/nfs41sys_debug.c
  263. @@ -55,6 +55,8 @@
  264.  #include <ntstrsafe.h>
  265.  #include <winerror.h>
  266.  
  267. +#include "win_reparse.h"
  268. +
  269.  //#define INCLUDE_TIMESTAMPS
  270.  
  271.  ULONG __cdecl DbgP(IN PCCH fmt, ...)
  272. @@ -1028,6 +1030,71 @@ const char *fsctl2string(ULONG fscontrolcode)
  273.      /* not reached */
  274.  }
  275.  
  276. +const char *reparsetag2string(ULONG tag)
  277. +{
  278. +#define REPARSETAG2STR_RET(x) case (x): return #x ; break
  279. +    switch(tag) {
  280. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_MOUNT_POINT);
  281. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_HSM);
  282. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_DRIVE_EXTENDER);
  283. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_HSM2);
  284. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_SIS);
  285. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_WIM);
  286. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_CSV);
  287. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_DFS);
  288. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_FILTER_MANAGER);
  289. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_SYMLINK);
  290. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_IIS_CACHE);
  291. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_DFSR);
  292. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_DEDUP);
  293. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_APPXSTRM);
  294. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_NFS);
  295. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_FILE_PLACEHOLDER);
  296. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_DFM);
  297. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_WOF);
  298. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_WCI);
  299. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_WCI_1);
  300. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_GLOBAL_REPARSE);
  301. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_CLOUD);
  302. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_CLOUD_1);
  303. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_CLOUD_2);
  304. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_CLOUD_3);
  305. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_CLOUD_4);
  306. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_CLOUD_5);
  307. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_CLOUD_6);
  308. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_CLOUD_7);
  309. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_CLOUD_8);
  310. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_CLOUD_9);
  311. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_CLOUD_A);
  312. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_CLOUD_B);
  313. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_CLOUD_C);
  314. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_CLOUD_D);
  315. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_CLOUD_E);
  316. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_CLOUD_F);
  317. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_APPEXECLINK);
  318. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_PROJFS);
  319. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_LX_SYMLINK);
  320. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_STORAGE_SYNC);
  321. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_STORAGE_SYNC_FOLDER);
  322. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_WCI_TOMBSTONE);
  323. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_UNHANDLED);
  324. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_ONEDRIVE);
  325. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_PROJFS_TOMBSTONE);
  326. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_AF_UNIX);
  327. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_LX_FIFO);
  328. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_LX_CHR);
  329. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_LX_BLK);
  330. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_WCI_LINK);
  331. +        REPARSETAG2STR_RET(IO_REPARSE_TAG_WCI_LINK_1);
  332. +        default:
  333. +            return "<unknown reparse tag>";
  334. +            break;
  335. +    }
  336. +
  337. +    /* not reached */
  338. +}
  339. +
  340. +
  341.  #ifdef USE_LOOKASIDELISTS_FOR_UPDOWNCALLENTRY_MEM
  342.  void print_lookasidelist_stat(const char *label, PNPAGED_LOOKASIDE_LIST ll)
  343.  {
  344. diff --git a/sys/nfs41sys_debug.h b/sys/nfs41sys_debug.h
  345. index 29bb339..4570cde 100644
  346. --- a/sys/nfs41sys_debug.h
  347. +++ b/sys/nfs41sys_debug.h
  348. @@ -56,6 +56,7 @@ void print_wait_status(int on, const char *str, NTSTATUS status,
  349.                         const char *opcode, PVOID entry, LONGLONG xid);
  350.  void print_acl_args(SECURITY_INFORMATION info);
  351.  const char *fsctl2string(ULONG fsctl);
  352. +const char *reparsetag2string(ULONG tag);
  353.  #ifdef USE_LOOKASIDELISTS_FOR_UPDOWNCALLENTRY_MEM
  354.  void print_lookasidelist_stat(const char *label, PNPAGED_LOOKASIDE_LIST ll);
  355.  #endif /* USE_LOOKASIDELISTS_FOR_UPDOWNCALLENTRY_MEM */
  356. diff --git a/sys/nfs41sys_driver.h b/sys/nfs41sys_driver.h
  357. index 8bb88bc..f14beb5 100644
  358. --- a/sys/nfs41sys_driver.h
  359. +++ b/sys/nfs41sys_driver.h
  360. @@ -774,6 +774,12 @@ NTSTATUS marshal_nfs41_symlink(
  361.  void unmarshal_nfs41_symlink(
  362.      nfs41_updowncall_entry *cur,
  363.      unsigned char **buf);
  364. +NTSTATUS nfs41_SetSymlinkReparsePoint(
  365. +    IN OUT PRX_CONTEXT RxContext);
  366. +NTSTATUS nfs41_GetSymlinkReparsePoint(
  367. +    IN OUT PRX_CONTEXT RxContext);
  368. +
  369. +/* nfs41sys_reparse.c */
  370.  NTSTATUS nfs41_SetReparsePoint(
  371.      IN OUT PRX_CONTEXT RxContext);
  372.  NTSTATUS nfs41_GetReparsePoint(
  373. diff --git a/sys/nfs41sys_reparse.c b/sys/nfs41sys_reparse.c
  374. new file mode 100644
  375. index 0000000..0b1e726
  376. --- /dev/null
  377. +++ b/sys/nfs41sys_reparse.c
  378. @@ -0,0 +1,117 @@
  379. +/* NFSv4.1 client for Windows
  380. + * Copyright (C) 2012 The Regents of the University of Michigan
  381. + * Copyright (C) 2023-2025 Roland Mainz <roland.mainz@nrubsig.org>
  382. + *
  383. + * Olga Kornievskaia <aglo@umich.edu>
  384. + * Casey Bodley <cbodley@umich.edu>
  385. + * Roland Mainz <roland.mainz@nrubsig.org>
  386. + *
  387. + * This library is free software; you can redistribute it and/or modify it
  388. + * under the terms of the GNU Lesser General Public License as published by
  389. + * the Free Software Foundation; either version 2.1 of the License, or (at
  390. + * your option) any later version.
  391. + *
  392. + * This library is distributed in the hope that it will be useful, but
  393. + * without any warranty; without even the implied warranty of merchantability
  394. + * or fitness for a particular purpose.  See the GNU Lesser General Public
  395. + * License for more details.
  396. + *
  397. + * You should have received a copy of the GNU Lesser General Public License
  398. + * along with this library; if not, write to the Free Software Foundation,
  399. + * Inc., 51 Franklin Street, Fifth Floor, Boston, MA
  400. + */
  401. +
  402. +#ifndef _KERNEL_MODE
  403. +#error module requires kernel mode
  404. +#endif
  405. +
  406. +#if ((__STDC_VERSION__-0) < 201710L)
  407. +#error Code requires ISO C17
  408. +#endif
  409. +
  410. +/* FIXME: Why does VS22 need this, but not VC19 ? */
  411. +#if _MSC_VER >= 1900
  412. +#if defined(_WIN64) && defined(_M_X64)
  413. +#ifndef _AMD64_
  414. +#define _AMD64_
  415. +#endif
  416. +#elif defined(_WIN32) && defined(_M_IX86)
  417. +#ifndef _X86_
  418. +#define _X86_
  419. +#endif
  420. +#elif defined(_WIN64) && defined(_M_ARM64)
  421. +#ifndef _ARM64_
  422. +#define _ARM64_
  423. +#endif
  424. +#elif defined(_WIN32) && defined(_M_ARM)
  425. +#ifndef _ARM_
  426. +#define _ARM_
  427. +#endif
  428. +#else
  429. +#error Unsupported arch
  430. +#endif
  431. +#endif /* _MSC_VER >= 1900 */
  432. +
  433. +#define MINIRDR__NAME "Value is ignored, only fact of definition"
  434. +#include <rx.h>
  435. +#include <windef.h>
  436. +#include <winerror.h>
  437. +
  438. +#include <Ntstrsafe.h>
  439. +
  440. +#include "nfs41sys_buildconfig.h"
  441. +
  442. +#include "nfs41_driver.h"
  443. +#include "nfs41sys_debug.h"
  444. +#include "nfs41_build_features.h"
  445. +
  446. +#include "nfs41sys_driver.h"
  447. +#include "nfs41sys_util.h"
  448. +
  449. +#include "win_reparse.h"
  450. +
  451. +
  452. +
  453. +NTSTATUS nfs41_SetReparsePoint(
  454. +    IN OUT PRX_CONTEXT RxContext)
  455. +{
  456. +    NTSTATUS status;
  457. +    __notnull XXCTL_LOWIO_COMPONENT *FsCtl = &RxContext->LowIoContext.ParamsFor.FsCtl;
  458. +    __notnull PREPARSE_DATA_BUFFER Reparse = (PREPARSE_DATA_BUFFER)FsCtl->pInputBuffer;
  459. +
  460. +    DbgEn();
  461. +
  462. +    DbgP("nfs41_SetReparsePoint: ReparseTag: '%s'/0x%04lx\n",
  463. +        reparsetag2string(Reparse->ReparseTag),
  464. +        (long)Reparse->ReparseTag);
  465. +
  466. +    switch(Reparse->ReparseTag) {
  467. +        case IO_REPARSE_TAG_SYMLINK:
  468. +            status = nfs41_SetSymlinkReparsePoint(RxContext);
  469. +            break;
  470. +        default:
  471. +            status = STATUS_NOT_IMPLEMENTED;
  472. +            DbgP("nfs41_SetReparsePoint: "
  473. +                "Unsupported ReparseTag: '%s'/0x%04lx\n",
  474. +                reparsetag2string(Reparse->ReparseTag),
  475. +                (long)Reparse->ReparseTag);
  476. +            break;
  477. +    }
  478. +
  479. +    DbgEx();
  480. +    return status;
  481. +}
  482. +
  483. +
  484. +NTSTATUS nfs41_GetReparsePoint(
  485. +    IN OUT PRX_CONTEXT RxContext)
  486. +{
  487. +    NTSTATUS status;
  488. +
  489. +    DbgEn();
  490. +
  491. +    status = nfs41_GetSymlinkReparsePoint(RxContext);
  492. +
  493. +    DbgEx();
  494. +    return status;
  495. +}
  496. diff --git a/sys/nfs41sys_symlink.c b/sys/nfs41sys_symlink.c
  497. index b6cacd5..f44f0bd 100644
  498. --- a/sys/nfs41sys_symlink.c
  499. +++ b/sys/nfs41sys_symlink.c
  500. @@ -68,6 +68,8 @@
  501.  #include "nfs41sys_driver.h"
  502.  #include "nfs41sys_util.h"
  503.  
  504. +#include "win_reparse.h"
  505. +
  506.  
  507.  NTSTATUS marshal_nfs41_symlink(
  508.      nfs41_updowncall_entry *entry,
  509. @@ -248,7 +250,7 @@ out:
  510.      return status;
  511.  }
  512.  
  513. -NTSTATUS nfs41_SetReparsePoint(
  514. +NTSTATUS nfs41_SetSymlinkReparsePoint(
  515.      IN OUT PRX_CONTEXT RxContext)
  516.  {
  517.      NTSTATUS status;
  518. @@ -268,9 +270,15 @@ NTSTATUS nfs41_SetReparsePoint(
  519.      print_debug_header(RxContext);
  520.      print_reparse_buffer(Reparse);
  521.  #endif
  522. +
  523. +    DbgP("nfs41_SetSymlinkReparsePoint: ReparseTag: '%s'/0x%04lx\n",
  524. +        reparsetag2string(Reparse->ReparseTag),
  525. +        (long)Reparse->ReparseTag);
  526. +
  527.      status = check_nfs41_setreparse_args(RxContext);
  528.      if (status) goto out;
  529.  
  530. +
  531.      TargetName.MaximumLength = TargetName.Length =
  532.          Reparse->SymbolicLinkReparseBuffer.PrintNameLength;
  533.      TargetName.Buffer = &Reparse->SymbolicLinkReparseBuffer.PathBuffer[
  534. @@ -337,7 +345,7 @@ out:
  535.      return status;
  536.  }
  537.  
  538. -NTSTATUS nfs41_GetReparsePoint(
  539. +NTSTATUS nfs41_GetSymlinkReparsePoint(
  540.      IN OUT PRX_CONTEXT RxContext)
  541.  {
  542.      NTSTATUS status;
  543. --
  544. 2.45.1
  545.  
  546. From af78a97ded864d4a2ba5322140e853535ae03539 Mon Sep 17 00:00:00 2001
  547. From: Roland Mainz <roland.mainz@nrubsig.org>
  548. Date: Mon, 3 Feb 2025 13:24:22 +0100
  549. Subject: [PATCH 2/8] build.vc19: Fix vcxproj include references
  550.  
  551. Fix vcxproj include references
  552.  
  553. Signed-off-by: Cedric Blancher <cedric.blancher@gmail.com>
  554. ---
  555. build.vc19/nfs41_driver/nfs41_driver.vcxproj         | 4 ++--
  556.  build.vc19/nfs41_driver/nfs41_driver.vcxproj.filters | 6 +++---
  557.  2 files changed, 5 insertions(+), 5 deletions(-)
  558.  
  559. diff --git a/build.vc19/nfs41_driver/nfs41_driver.vcxproj b/build.vc19/nfs41_driver/nfs41_driver.vcxproj
  560. index 1148548..44dd01f 100644
  561. --- a/build.vc19/nfs41_driver/nfs41_driver.vcxproj
  562. +++ b/build.vc19/nfs41_driver/nfs41_driver.vcxproj
  563. @@ -227,9 +227,9 @@
  564.    </ItemGroup>
  565.    <ItemGroup>
  566.      <ClInclude Include="..\..\sys\nfs41_debug.h" />
  567. -    <ClInclude Include="..\..\sys\nfs41_driver.h" />
  568.      <ClInclude Include="..\..\sys\wmlkm.h" />
  569. -    <ClInclude Include="..\..\daemon\nfs_ea.h" />
  570. +    <ClInclude Include="..\..\include\nfs41_driver.h" />
  571. +    <ClInclude Include="..\..\include\nfs_ea.h" />
  572.      <ClInclude Include="..\..\include\win_reparse.h" />
  573.    </ItemGroup>
  574.    <ItemGroup>
  575. diff --git a/build.vc19/nfs41_driver/nfs41_driver.vcxproj.filters b/build.vc19/nfs41_driver/nfs41_driver.vcxproj.filters
  576. index 49049a7..f055bf0 100644
  577. --- a/build.vc19/nfs41_driver/nfs41_driver.vcxproj.filters
  578. +++ b/build.vc19/nfs41_driver/nfs41_driver.vcxproj.filters
  579. @@ -81,13 +81,13 @@
  580.      <ClInclude Include="..\..\sys\nfs41_debug.h">
  581.        <Filter>Header Files</Filter>
  582.      </ClInclude>
  583. -    <ClInclude Include="..\..\sys\nfs41_driver.h">
  584. +    <ClInclude Include="..\..\sys\wmlkm.h">
  585.        <Filter>Header Files</Filter>
  586.      </ClInclude>
  587. -    <ClInclude Include="..\..\sys\wmlkm.h">
  588. +    <ClInclude Include="..\..\include\nfs41_driver.h">
  589.        <Filter>Header Files</Filter>
  590.      </ClInclude>
  591. -    <ClInclude Include="..\..\daemon\nfs_ea.h">
  592. +    <ClInclude Include="..\..\include\nfs_ea.h">
  593.        <Filter>Header Files</Filter>
  594.      </ClInclude>
  595.      <ClInclude Include="..\..\include\win_reparse.h">
  596. --
  597. 2.45.1
  598.  
  599. From b0cb9a9dde22cd1f8d4924ad8dcabd579f456cd7 Mon Sep 17 00:00:00 2001
  600. From: Roland Mainz <roland.mainz@nrubsig.org>
  601. Date: Mon, 3 Feb 2025 13:34:15 +0100
  602. Subject: [PATCH 3/8] tests: Document how to install WSL for testing
  603.  
  604. Document how to install WSL for testing
  605.  
  606. Signed-off-by: Cedric Blancher <cedric.blancher@gmail.com>
  607. ---
  608. tests/manual_testing.txt | 30 +++++++++++++++++++++++++++++-
  609.  1 file changed, 29 insertions(+), 1 deletion(-)
  610.  
  611. diff --git a/tests/manual_testing.txt b/tests/manual_testing.txt
  612. index 3f5b115..df99ad5 100644
  613. --- a/tests/manual_testing.txt
  614. +++ b/tests/manual_testing.txt
  615. @@ -1,5 +1,5 @@
  616.  #
  617. -# ms-nfs41-client manual testing sequence, 2025-01-08
  618. +# ms-nfs41-client manual testing sequence, 2025-02-03
  619.  #
  620.  # Draft version, needs to be turned into automated tests
  621.  # if possible
  622. @@ -513,5 +513,33 @@ bash /usr/share/msnfs41client/tests/misc/wintartest_comparewinvsgnu001.bash myta
  623.  bash -c 'set -o errexit ; rm -Rf sillytestdir ; mkdir sillytestdir ; cd sillytestdir ; touch sillytest ; ( command exec {n}<"sillytest" ; printf "fd=%d\n" $n ; sleep 10) & sleep 1 ; ls -la ; cmd /C "del sillytest" ; ls -la ; if [[ "$(ls -1 .nfs*)" != "" ]] ; then echo "# test OK" ; else echo "# test FAILED" ; fi ; wait'
  624.  bash -c 'set -o errexit ; rm -Rf sillytestdir ; mkdir sillytestdir ; cd sillytestdir ; touch sillytest ; ( command exec {n}<"sillytest" ; printf "fd=%d\n" $n ; sleep 10) & sleep 1 ; ls -la ; rm -f sillytest ; ls -la ; if [[ "$(ls -1 .nfs*)" != "" ]] ; then echo "# test OK" ; else echo "# test FAILED" ; fi ; wait'
  625.  
  626. +#
  627. +# WSL install for testing
  628. +#
  629. +
  630. +# install WSL
  631. +# (from Admin powershell)
  632. +wsl --install --web-download -d Debian
  633. +
  634. +# Update Debian Linux
  635. +# wsl # (enter WSL environment)
  636. +
  637. +$ sudo root
  638. +
  639. +# update /etc/apt/sources.list to include "contrib"+"non-free"
  640. +$ cat /etc/apt/sources.list
  641. +deb http://ftp.gwdg.de/debian/ bullseye main contrib non-free
  642. +deb-src http://ftp.gwdg.de/debian/ bullseye main contrib non-free
  643. +
  644. +deb http://security.debian.org/debian-security bullseye-security main contrib non-free
  645. +deb-src http://security.debian.org/debian-security bullseye-security main contrib non-free
  646. +
  647. +# update package lists+update packages
  648. +$ apt-get update
  649. +$ apt-get upgrade
  650. +
  651. +# install packages for testing
  652. +$ apt-get install clang gcc gdb nedit emacs vim x11-apps xterm ksh traceroute strace ddd mesa-utils tk xpdf xmpuzzles mwm xutils-dev valgrind crash libhugetlbfs-bin wireguard xtron x11-xserver-utils sunclock moreutils iproute2 inetutils-tools build-essential linux-source libncurses5-dev xvkbd ethtool tshark xmldiff krb5-user krb5-kdc libkrb5-dev keyutils info bc kmod cpio flex libncurses5-dev libelf-dev libssl-dev inkscape xdmx xdmx-tools twm mwm sbuild autoconf automake openbsd-inetd rwho rwhod finger fingerd cronutils at nfs-kernel-server nfs-common nfs4-acl-tools autofs openjdk-17-jdk openjdk-17-demo python talk talkd libcurl4 libc6-dbg sysvbanner powertop iftop acpidump linux-perf ltrace locales task-german task-japanese schroot groff squashfs-tools dpkg-dev devscripts kernel-wedge sbsigntool git-svn apt-file module-assistant dwarves tree net-tools bridge-utils xnest uml-utilities inxi libxaw7-dev whois extrace kexec-tools dos2unix pkg-config libglib2.0-dev libpixman-1-dev qemu qemu-utils qemu-system-\* qemu-system-gui libsixel-bin w3m-img sharutils freerdp2-x11 nscd debconf-utils iotop 'manpages-posix*' konsole lsof
  653. +
  654.  #
  655.  # EOF.
  656. --
  657. 2.45.1
  658.  
  659. From f61ca8306888cbac868af61a32b45eb3ae27fb79 Mon Sep 17 00:00:00 2001
  660. From: Roland Mainz <roland.mainz@nrubsig.org>
  661. Date: Mon, 3 Feb 2025 14:44:59 +0100
  662. Subject: [PATCH 4/8] sys: Improve symlink reparse point debug output
  663.  
  664. Improve symlink reparse point debug output
  665.  
  666. Signed-off-by: Cedric Blancher <cedric.blancher@gmail.com>
  667. ---
  668. sys/nfs41sys_symlink.c | 45 +++++++++++++++++++++++++++++++++++-------
  669.  1 file changed, 38 insertions(+), 7 deletions(-)
  670.  
  671. diff --git a/sys/nfs41sys_symlink.c b/sys/nfs41sys_symlink.c
  672. index f44f0bd..d01e8c9 100644
  673. --- a/sys/nfs41sys_symlink.c
  674. +++ b/sys/nfs41sys_symlink.c
  675. @@ -189,7 +189,7 @@ static void print_reparse_buffer(
  676.  }
  677.  
  678.  static
  679. -NTSTATUS check_nfs41_setreparse_args(
  680. +NTSTATUS check_nfs41_setsymlinkreparse_args(
  681.      IN PRX_CONTEXT RxContext)
  682.  {
  683.      NTSTATUS status = STATUS_SUCCESS;
  684. @@ -214,36 +214,50 @@ NTSTATUS check_nfs41_setreparse_args(
  685.       * or it's trying to operate on the volume itself */
  686.      if (is_root_directory(RxContext)) {
  687.          status = STATUS_INVALID_PARAMETER;
  688. +        DbgP("check_nfs41_setsymlinkreparse_args: "
  689. +            "is_root_directory() == TRUE\n");
  690.          goto out;
  691.      }
  692. +
  693.      if (FsCtl->pOutputBuffer != NULL) {
  694.          status = STATUS_INVALID_PARAMETER;
  695. +        DbgP("check_nfs41_setsymlinkreparse_args: "
  696. +            "FsCtl->pOutputBuffer == NULL\n");
  697.          goto out;
  698.      }
  699.  
  700.      /* validate input buffer and length */
  701.      if (!Reparse) {
  702.          status = STATUS_INVALID_BUFFER_SIZE;
  703. +        DbgP("check_nfs41_setsymlinkreparse_args: Reparse == NULL\n");
  704.          goto out;
  705.      }
  706.  
  707.      if (FsCtl->InputBufferLength < HeaderLen ||
  708.              FsCtl->InputBufferLength > MAXIMUM_REPARSE_DATA_BUFFER_SIZE) {
  709. +        DbgP("check_nfs41_setsymlinkreparse_args: "
  710. +            "InputBufferLength too small/large\n");
  711.          status = STATUS_IO_REPARSE_DATA_INVALID;
  712.          goto out;
  713.      }
  714.      if (FsCtl->InputBufferLength != HeaderLen + Reparse->ReparseDataLength) {
  715.          status = STATUS_IO_REPARSE_DATA_INVALID;
  716. +        DbgP("check_nfs41_setsymlinkreparse_args: "
  717. +            "InputBufferLength != HeaderLen + ReparseDataLength\n");
  718.          goto out;
  719.      }
  720.  
  721.      /* validate reparse tag */
  722.      if (!IsReparseTagValid(Reparse->ReparseTag)) {
  723.          status = STATUS_IO_REPARSE_TAG_INVALID;
  724. +        DbgP("check_nfs41_setsymlinkreparse_args: "
  725. +            "IsReparseTagValid() failed\n");
  726.          goto out;
  727.      }
  728.      if (Reparse->ReparseTag != IO_REPARSE_TAG_SYMLINK) {
  729.          status = STATUS_IO_REPARSE_TAG_MISMATCH;
  730. +        DbgP("check_nfs41_setsymlinkreparse_args: "
  731. +            "Reparse->ReparseTag != IO_REPARSE_TAG_SYMLINK\n");
  732.          goto out;
  733.      }
  734.  out:
  735. @@ -275,9 +289,14 @@ NTSTATUS nfs41_SetSymlinkReparsePoint(
  736.          reparsetag2string(Reparse->ReparseTag),
  737.          (long)Reparse->ReparseTag);
  738.  
  739. -    status = check_nfs41_setreparse_args(RxContext);
  740. -    if (status) goto out;
  741. -
  742. +    status = check_nfs41_setsymlinkreparse_args(RxContext);
  743. +    if (status) {
  744. +        DbgP("nfs41_SetSymlinkReparsePoint: "
  745. +            "check_nfs41_setsymlinkreparse_args() failed, "
  746. +            "status=0xlx\n",
  747. +                (long)status);
  748. +        goto out;
  749. +    }
  750.  
  751.      TargetName.MaximumLength = TargetName.Length =
  752.          Reparse->SymbolicLinkReparseBuffer.PrintNameLength;
  753. @@ -305,7 +324,7 @@ out:
  754.  }
  755.  
  756.  static
  757. -NTSTATUS check_nfs41_getreparse_args(
  758. +NTSTATUS check_nfs41_getsymlinkreparse_args(
  759.      PRX_CONTEXT RxContext)
  760.  {
  761.      NTSTATUS status = STATUS_SUCCESS;
  762. @@ -317,6 +336,8 @@ NTSTATUS check_nfs41_getreparse_args(
  763.       * or it's trying to operate on the volume itself */
  764.      if (is_root_directory(RxContext)) {
  765.          status = STATUS_INVALID_PARAMETER;
  766. +        DbgP("check_nfs41_getsymlinkreparse_args: "
  767. +            "is_root_directory() == TRUE\n");
  768.          goto out;
  769.      }
  770.      /* ifs reparse tests expect STATUS_INVALID_PARAMETER,
  771. @@ -327,6 +348,8 @@ NTSTATUS check_nfs41_getreparse_args(
  772.      } */
  773.      if (!FsCtl->pOutputBuffer) {
  774.          status = STATUS_INVALID_USER_BUFFER;
  775. +        DbgP("check_nfs41_getsymlinkreparse_args: "
  776. +            "FsCtl->pOutputBuffer == NULL\n");
  777.          goto out;
  778.      }
  779.      if (!BooleanFlagOn(RxContext->pFcb->Attributes,
  780. @@ -339,6 +362,8 @@ NTSTATUS check_nfs41_getreparse_args(
  781.      if (FsCtl->OutputBufferLength < HeaderLen) {
  782.          RxContext->InformationToReturn = HeaderLen;
  783.          status = STATUS_BUFFER_TOO_SMALL;
  784. +        DbgP("check_nfs41_getsymlinkreparse_args: "
  785. +            "FsCtl->OutputBufferLength < HeaderLen\n");
  786.          goto out;
  787.      }
  788.  out:
  789. @@ -364,8 +389,14 @@ NTSTATUS nfs41_GetSymlinkReparsePoint(
  790.  #ifdef DEBUG_SYMLINK
  791.      DbgEn();
  792.  #endif
  793. -    status = check_nfs41_getreparse_args(RxContext);
  794. -    if (status) goto out;
  795. +    status = check_nfs41_getsymlinkreparse_args(RxContext);
  796. +    if (status) {
  797. +        DbgP("nfs41_GetSymlinkReparsePoint: "
  798. +            "check_nfs41_getsymlinkreparse_args() failed, "
  799. +            "status=0xlx\n",
  800. +                (long)status);
  801. +        goto out;
  802. +    }
  803.  
  804.      TargetName.Buffer = (PWCH)((PBYTE)FsCtl->pOutputBuffer + HeaderLen);
  805.      TargetName.MaximumLength = (USHORT)min(FsCtl->OutputBufferLength -
  806. --
  807. 2.45.1
  808.  
  809. From df131fabe4d7d58879691bd029f0a98f796dd80d Mon Sep 17 00:00:00 2001
  810. From: Roland Mainz <roland.mainz@nrubsig.org>
  811. Date: Mon, 3 Feb 2025 15:02:05 +0100
  812. Subject: [PATCH 5/8] sys,tests: cmd /C "mklink" builtin&co. should be able to
  813.  create symbolic links
  814.  
  815. cmd /C "mklink" builtin&co. should be able to create symbolic links.
  816. This failed because we were looking for an output buffer
  817. which is only required for |FSCTL_GET_REPARSE_POINT|, but not
  818. for |FSCTL_SET_REPARSE_POINT|.
  819.  
  820. Reported-by: Takeshi Nishimura <takeshi.nishimura.linux@gmail.com>
  821. Signed-off-by: Cedric Blancher <cedric.blancher@gmail.com>
  822. ---
  823. sys/nfs41sys_symlink.c   |  7 -------
  824.  tests/manual_testing.txt | 20 ++++++++++++++++++++
  825.  2 files changed, 20 insertions(+), 7 deletions(-)
  826.  
  827. diff --git a/sys/nfs41sys_symlink.c b/sys/nfs41sys_symlink.c
  828. index d01e8c9..6e04074 100644
  829. --- a/sys/nfs41sys_symlink.c
  830. +++ b/sys/nfs41sys_symlink.c
  831. @@ -219,13 +219,6 @@ NTSTATUS check_nfs41_setsymlinkreparse_args(
  832.          goto out;
  833.      }
  834.  
  835. -    if (FsCtl->pOutputBuffer != NULL) {
  836. -        status = STATUS_INVALID_PARAMETER;
  837. -        DbgP("check_nfs41_setsymlinkreparse_args: "
  838. -            "FsCtl->pOutputBuffer == NULL\n");
  839. -        goto out;
  840. -    }
  841. -
  842.      /* validate input buffer and length */
  843.      if (!Reparse) {
  844.          status = STATUS_INVALID_BUFFER_SIZE;
  845. diff --git a/tests/manual_testing.txt b/tests/manual_testing.txt
  846. index df99ad5..f8a006c 100644
  847. --- a/tests/manual_testing.txt
  848. +++ b/tests/manual_testing.txt
  849. @@ -159,6 +159,26 @@ ksh93 -c 'builtin id ; rm -f x ; touch x ; chown "$(id -u -n):$(id -g -n)" x &&
  850.  ksh93 -c 'builtin id ; rm -f x ; touch x ; chgrp "$(id -g -n)" x && print OK'
  851.  ---- snip ----
  852.  
  853. +#
  854. +# Test for native mklink  && powershell New-Item -ItemType SymbolicLink
  855. +#
  856. +# Notes:
  857. +# - powershell might require admin rights depending on Windows
  858. +# registry settings)
  859. +#
  860. +
  861. +# 1. cmd.exe mklink dir
  862. +mkdir mydir1
  863. +cmd /C 'mklink /D symLinkmydir1 mydir1'
  864. +# 2. cmd.exe mklink file
  865. +touch myfile1
  866. +cmd /C 'mklink symLinkmyfile myfile1'
  867. +# 3. powershell mklink dir
  868. +mkdir mypsdir1
  869. +powershell -Command 'New-Item -Path sym_mypsdir1 -ItemType SymbolicLink -Value mypsdir1'
  870. +# 4. powershell mklink file
  871. +mkdir mypsfile1
  872. +powershell -Command 'New-Item -Path sym_mypsfile1 -ItemType SymbolicLink -Value mypsfile1'
  873.  
  874.  #
  875.  # Tests for groups
  876. --
  877. 2.45.1
  878.  
  879. From fef28d909cc0a29c1c1cc8b333aea2d644797900 Mon Sep 17 00:00:00 2001
  880. From: Roland Mainz <roland.mainz@nrubsig.org>
  881. Date: Mon, 3 Feb 2025 18:43:13 +0100
  882. Subject: [PATCH 6/8] daemon: Improve EA error reporting
  883.  
  884. Improve EA error reporting, e.g for Solaris and WSL support.
  885.  
  886. Signed-off-by: Cedric Blancher <cedric.blancher@gmail.com>
  887. ---
  888. daemon/ea.c | 33 +++++++++++++++++++++++++--------
  889.  1 file changed, 25 insertions(+), 8 deletions(-)
  890.  
  891. diff --git a/daemon/ea.c b/daemon/ea.c
  892. index bedd860..3151b25 100644
  893. --- a/daemon/ea.c
  894. +++ b/daemon/ea.c
  895. @@ -52,7 +52,8 @@ static int set_ea_value(
  896.  
  897.      /* don't allow values larger than NFS4_EASIZE */
  898.      if (ea->EaValueLength > NFS4_EASIZE) {
  899. -        eprintf("trying to write extended attribute value of size %d, "
  900. +        eprintf("set_ea_value: "
  901. +            "trying to write extended attribute value of size %d, "
  902.              "max allowed %d\n", ea->EaValueLength, NFS4_EASIZE);
  903.          status = NFS4ERR_FBIG;
  904.          goto out;
  905. @@ -83,7 +84,11 @@ static int set_ea_value(
  906.          OPEN4_SHARE_DENY_BOTH, OPEN4_CREATE, UNCHECKED4,
  907.          &createattrs, TRUE, &stateid.stateid, &delegation, NULL);
  908.      if (status) {
  909. -        eprintf("nfs41_open() failed with '%s'\n", nfs_error_string(status));
  910. +        eprintf("set_ea_value: "
  911. +            "nfs41_open(ea_name='%.*s') failed with '%s'\n",
  912. +            (int)ea->EaNameLength,
  913. +            ea->EaName,
  914. +            nfs_error_string(status));
  915.          goto out;
  916.      }
  917.  
  918. @@ -92,7 +97,11 @@ static int set_ea_value(
  919.          ea->EaValueLength, 0, FILE_SYNC4, &bytes_written,
  920.          &verf, NULL);
  921.      if (status) {
  922. -        eprintf("nfs41_write() failed with '%s'\n", nfs_error_string(status));
  923. +        eprintf("set_ea_value: "
  924. +            "nfs41_write(ea_name='%.*s') failed with '%s'\n",
  925. +            (int)ea->EaNameLength,
  926. +            ea->EaName,
  927. +            nfs_error_string(status));
  928.          goto out_close;
  929.      }
  930.  
  931. @@ -125,7 +134,8 @@ int nfs41_ea_set(
  932.  
  933.      status = nfs41_rpc_openattr(state->session, &state->file, TRUE, &attrdir.fh);
  934.      if (status) {
  935. -        eprintf("nfs41_rpc_openattr() failed with error '%s'\n",
  936. +        eprintf("nfs41_ea_set: "
  937. +            "nfs41_rpc_openattr() failed with error '%s'\n",
  938.              nfs_error_string(status));
  939.          goto out;
  940.      }
  941. @@ -447,7 +457,11 @@ static int get_ea_value(
  942.          OPEN4_SHARE_DENY_WRITE, OPEN4_NOCREATE, UNCHECKED4, NULL, TRUE,
  943.          &stateid.stateid, &delegation, &info);
  944.      if (status) {
  945. -        eprintf("nfs41_open() failed with '%s'\n", nfs_error_string(status));
  946. +        eprintf("get_ea_value: "
  947. +            "nfs41_open(ea_name='%.*s') failed with '%s'\n",
  948. +            (int)ea->EaNameLength,
  949. +            ea->EaName,
  950. +            nfs_error_string(status));
  951.          if (status == NFS4ERR_NOENT)
  952.              goto out_empty;
  953.          goto out;
  954. @@ -455,7 +469,8 @@ static int get_ea_value(
  955.  
  956.      if (info.size > NFS4_EASIZE) {
  957.          status = NFS4ERR_FBIG;
  958. -        eprintf("EA value for '%s' longer than maximum %u "
  959. +        eprintf("get_ea_value: "
  960. +            "EA value for '%s' longer than maximum %u "
  961.              "(%llu bytes), returning %s\n", ea->EaName, NFS4_EASIZE,
  962.              info.size, nfs_error_string(status));
  963.          goto out_close;
  964. @@ -476,7 +491,8 @@ static int get_ea_value(
  965.      status = nfs41_read(session, &file, &stateid,
  966.          0, length - diff, buffer, &bytes_read, &eof);
  967.      if (status) {
  968. -        eprintf("nfs41_read() failed with '%s'\n", nfs_error_string(status));
  969. +        eprintf("get_ea_value: nfs41_read() failed with '%s'\n",
  970. +            nfs_error_string(status));
  971.          goto out_close;
  972.      }
  973.      if (!eof) {
  974. @@ -551,7 +567,8 @@ static int handle_getexattr(void *daemon_context, nfs41_upcall *upcall)
  975.              goto out;
  976.          }
  977.      } else if (status) {
  978. -        eprintf("nfs41_rpc_openattr() failed with '%s'\n",
  979. +        eprintf("handle_getexattr: "
  980. +            "nfs41_rpc_openattr() failed with '%s'\n",
  981.              nfs_error_string(status));
  982.          status = nfs_to_windows_error(status, ERROR_EAS_NOT_SUPPORTED);
  983.          goto out;
  984. --
  985. 2.45.1
  986.  
  987. From 11bcd4201d597feb01a0364fd6d3145246ccea8e Mon Sep 17 00:00:00 2001
  988. From: Roland Mainz <roland.mainz@nrubsig.org>
  989. Date: Mon, 3 Feb 2025 18:45:04 +0100
  990. Subject: [PATCH 7/8] daemon: Add |debug_print_ea()| for |handle_open()&co. to
  991.  print EA info
  992.  
  993. Add |debug_print_ea()| for |handle_open()&co. to print EA info
  994.  
  995. Signed-off-by: Cedric Blancher <cedric.blancher@gmail.com>
  996. ---
  997. daemon/daemon_debug.c | 31 +++++++++++++++++++++++++++++++
  998.  daemon/daemon_debug.h |  3 +++
  999.  daemon/open.c         |  7 +++++++
  1000.  3 files changed, 41 insertions(+)
  1001.  
  1002. diff --git a/daemon/daemon_debug.c b/daemon/daemon_debug.c
  1003. index 03eeda7..5c48f78 100644
  1004. --- a/daemon/daemon_debug.c
  1005. +++ b/daemon/daemon_debug.c
  1006. @@ -1360,3 +1360,34 @@ void debug_delayed_free(void *in_ptr)
  1007.      debug_delay_free_data.free_ptrs[i] = in_ptr;
  1008.      ReleaseSRWLockExclusive(&debug_delay_free_data.lock);
  1009.  }
  1010. +
  1011. +void debug_print_ea(PFILE_FULL_EA_INFORMATION ea)
  1012. +{
  1013. +    PFILE_FULL_EA_INFORMATION print_ea = ea;
  1014. +
  1015. +    dprintf_out("--> debug_print_ea(ea=0x%p)\n", ea);
  1016. +    if (ea == NULL)
  1017. +        goto out;
  1018. +
  1019. +#define EA_NEXT_ENTRY(ea) ((PBYTE)(ea) + (ea)->NextEntryOffset)
  1020. +#define EA_VALUE(ea) \
  1021. +    ((void *)((unsigned char*)(ea)->EaName + (ea)->EaNameLength + 1))
  1022. +
  1023. +    while (1) {
  1024. +        const char *ea_name = print_ea->EaName;
  1025. +        size_t ea_name_len = print_ea->EaNameLength;
  1026. +
  1027. +        dprintf_out("EA name='%.*s', value_len=%d\n",
  1028. +            (int)print_ea->EaNameLength,
  1029. +            print_ea->EaName,
  1030. +            (int)print_ea->EaValueLength);
  1031. +
  1032. +        if (print_ea->NextEntryOffset == 0)
  1033. +            break;
  1034. +        print_ea = (PFILE_FULL_EA_INFORMATION)EA_NEXT_ENTRY(print_ea);
  1035. +    }
  1036. +
  1037. +out:
  1038. +    dprintf_out("<-- debug_print_ea()\n");
  1039. +
  1040. +}
  1041. \ No newline at end of file
  1042. diff --git a/daemon/daemon_debug.h b/daemon/daemon_debug.h
  1043. index 2d4cc93..b39a312 100644
  1044. --- a/daemon/daemon_debug.h
  1045. +++ b/daemon/daemon_debug.h
  1046. @@ -175,4 +175,7 @@ void debug_ptr_add_recently_deleted(void *in_ptr);
  1047.  
  1048.  void debug_delayed_free(void *in_ptr);
  1049.  
  1050. +typedef struct _FILE_FULL_EA_INFORMATION FILE_FULL_EA_INFORMATION, *PFILE_FULL_EA_INFORMATION;
  1051. +void debug_print_ea(PFILE_FULL_EA_INFORMATION ea);
  1052. +
  1053.  #endif
  1054. diff --git a/daemon/open.c b/daemon/open.c
  1055. index 9ef5335..f3bf048 100644
  1056. --- a/daemon/open.c
  1057. +++ b/daemon/open.c
  1058. @@ -1072,6 +1072,13 @@ create_chgrp_out:
  1059.          }
  1060.  
  1061.          /* set extended attributes on file creation */
  1062. +        if (DPRINTF_LEVEL_ENABLED(1)) {
  1063. +            if (args->ea)
  1064. +                debug_print_ea(args->ea);
  1065. +            else
  1066. +                DPRINTF(1, ("handle_open: No EA\n"));
  1067. +        }
  1068. +
  1069.          if (args->ea && create_with_ea(args->disposition, lookup_status)) {
  1070.              status = nfs41_ea_set(state, args->ea);
  1071.              status = nfs_to_windows_error(status, ERROR_FILE_NOT_FOUND);
  1072. --
  1073. 2.45.1
  1074.  
  1075. From ed6bc4b30e68531305793c7571ca736c36944bc6 Mon Sep 17 00:00:00 2001
  1076. From: Roland Mainz <roland.mainz@nrubsig.org>
  1077. Date: Mon, 3 Feb 2025 18:46:47 +0100
  1078. Subject: [PATCH 8/8] daemon: Add WSL support to |debug_print_ea()|
  1079.  
  1080. Add WSL support to |debug_print_ea()|.
  1081.  
  1082. Signed-off-by: Cedric Blancher <cedric.blancher@gmail.com>
  1083. ---
  1084. daemon/daemon_debug.c | 39 +++++++++++++++++++++++++++++++++++----
  1085.  1 file changed, 35 insertions(+), 4 deletions(-)
  1086.  
  1087. diff --git a/daemon/daemon_debug.c b/daemon/daemon_debug.c
  1088. index 5c48f78..74f26bc 100644
  1089. --- a/daemon/daemon_debug.c
  1090. +++ b/daemon/daemon_debug.c
  1091. @@ -1377,10 +1377,41 @@ void debug_print_ea(PFILE_FULL_EA_INFORMATION ea)
  1092.          const char *ea_name = print_ea->EaName;
  1093.          size_t ea_name_len = print_ea->EaNameLength;
  1094.  
  1095. -        dprintf_out("EA name='%.*s', value_len=%d\n",
  1096. -            (int)print_ea->EaNameLength,
  1097. -            print_ea->EaName,
  1098. -            (int)print_ea->EaValueLength);
  1099. +#ifdef NFS41_DRIVER_WSL_SUPPORT
  1100. +        /*
  1101. +         * WSL EAs: See
  1102. +         * https://learn.microsoft.com/en-us/windows/wsl/file-permissions
  1103. +         * for a description
  1104. +         */
  1105. +        if (!strncmp(ea_name, "$LXUID", ea_name_len)) {
  1106. +            dprintf_out("EA name='%.*s', value_len=%d type=WSL_UID uid=%ld\n",
  1107. +                (int)print_ea->EaNameLength,
  1108. +                print_ea->EaName,
  1109. +                (int)print_ea->EaValueLength,
  1110. +                (long)(*((DWORD *)EA_VALUE(ea))));
  1111. +        }
  1112. +        else if (!strncmp(ea_name, "$LXGID", ea_name_len)) {
  1113. +            dprintf_out("EA name='%.*s', value_len=%d type=WSL_GID gid=%ld\n",
  1114. +                (int)print_ea->EaNameLength,
  1115. +                print_ea->EaName,
  1116. +                (int)print_ea->EaValueLength,
  1117. +                (long)(*((DWORD *)EA_VALUE(ea))));
  1118. +        }
  1119. +        else if (!strncmp(ea_name, "$LXMOD", ea_name_len)) {
  1120. +            dprintf_out("EA name='%.*s', value_len=%d type=WSL_MODE mode=0%lo\n",
  1121. +                (int)print_ea->EaNameLength,
  1122. +                print_ea->EaName,
  1123. +                (int)print_ea->EaValueLength,
  1124. +                (long)(*((DWORD *)EA_VALUE(ea))));
  1125. +        }
  1126. +        else
  1127. +#endif /* NFS41_DRIVER_WSL_SUPPORT */
  1128. +        {
  1129. +            dprintf_out("EA name='%.*s', value_len=%d\n",
  1130. +                (int)print_ea->EaNameLength,
  1131. +                print_ea->EaName,
  1132. +                (int)print_ea->EaValueLength);
  1133. +        }
  1134.  
  1135.          if (print_ea->NextEntryOffset == 0)
  1136.              break;
  1137. --
  1138. 2.45.1

Submit a correction or amendment below (click here to make a fresh posting)
After submitting an amendment, you'll be able to view the differences between the old and new posts easily.

Syntax highlighting:

To highlight particular lines, prefix each line with {%HIGHLIGHT}




All content is user-submitted.
The administrators of this site (kpaste.net) are not responsible for their content.
Abuse reports should be emailed to us at